-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: LVGL - Light and Versatile Graphics Library build_tarballs.jl #9614
base: master
Are you sure you want to change the base?
Conversation
LVGL - Light and Versatile Graphics Library https://github.com/lvgl/lvgl
Platform("x86_64", "macos"; ), | ||
Platform("aarch64", "linux"; libc="glibc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very odd list of platforms. Why does it only build on these two specific ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the only two platforms that I am able to test (my dev laptop and my embedded target board).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch has a lot of changes, and they aren't documented. Why is this patch needed here in Yggdrasil, and will you send it upstream so we don't have to try keeping it updated when a new version is introduced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair question. I probably should have split the patch up to make the purpose of the different parts more obvious.
Here is a summary:
CMakeLists.txt
and custom.cmake
-- This is cmake configuration to build LVGL as shared libraries and using the SDL2 backend (based on the example here).
lv_conf_template.h
-- This is build configuration to enable SDL2 integration (based on the example here)
lv_font.[ch]
-- This is an access function to allow access to const struct
font definitions. As far as I know, Libdl does not provide a way to access a const struct
defined in a dynamic library (dlsym
only returns function pointers). This access function is probably not interesting to the upstream project. I assume they are focused on supporting users who are accessing the library from C.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been sent upstream? I would guess we aren't the only ones seeing this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt anyone else would be using the very old (2016) version of the MacOS system headers that are used by BinaryBuilder.jl
So, this isn't suitable to send upstream. It's just a hack to build using Yggdrasil's outdated cross compiler setup.
LVGL - Light and Versatile Graphics Library
https://github.com/lvgl/lvgl